Backport #9098: test: fix flaky test-child-process-fork-dgram#9559
Closed
Trott wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
Backport #9098: test: fix flaky test-child-process-fork-dgram#9559Trott wants to merge 1 commit intonodejs:v4.x-stagingfrom
Trott wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
`test-child-process-fork-dgram` is unreliable on some platforms, especially FreeBSD and AIX within the project's continuous integration testing. It has also been observed to be flaky on macos. * Confirm child has received the server before sending packets * Close the server instance on the parent or child after receiving a Refs: nodejs#8697 Fixes: nodejs#8949 Fixes: nodejs#8271 PR-URL: nodejs#9098 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
2 tasks
mscdex
added
the
child_process
Contributor
|
landed in 4a6bd86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9098 for v4.x. /cc @thealphanerd
Description of change
test-child-process-fork-dgramis unreliable on some platforms,especially FreeBSD and AIX within the project's continuous integration
testing. It has also been observed to be flaky on macos.
Refs: #8697
Fixes: #8949
Fixes: #8271
PR-URL: #9098
Reviewed-By: Santiago Gimeno santiago.gimeno@gmail.com